0.13 Release

[davidhewitt]

So I think we are getting close to releasing 0.13; I wanted to open this issue just to plan what still needs to be done:

• ABI3 min version Add abi3-py* features #1263
• I would like to include the macro tidy up types: refactor native_type macros #1279 , because it needs to coordinate with a rust-numpy release anyway.
• Bugfix Do not include the double quotes in #[pyclass(name = "literal")] #1303
• Document abi shortcomings Clearly document the limitations of abi3 #1318
• ABI3 u128/i128 conversions Faster conversion from u128/i128 to PyLong with abi3 #1315
• Rename internal crates macros: rename crates for consistency #1317
• abi3-py36 build has a problem with cargo test abi3-py36 now passes tests #1320
• get runtime version_info() python: add version() to get running version #1322

Also do we have anything we need to add to the migration guide or any other new features which need better docs before releasing?

[alex]

Wooo! I'm very excited to see the abi3 work in a release.

[alex]

Besides the work to complete #1279, is there anything else that needs doing to be able to release?

[kngwyu]

I don't see any blocker and am preparing the release.

[davidhewitt]

I would suggest we also include the bugfix #1303

It's new functionality in 0.13 which is currently implemented incorrectly

[davidhewitt]

I think we're getting close now. I'd still like to have a decision on #1279, because it fixes some missing trait impls and cleans up other code.

Also I just remembered #1288 - if we can do something about this before the release, I think it'd be very helpful for users.

[davidhewitt]

I updated the list at the top of the issue with the PRs which we're waiting to have merged before the release.

[kngwyu]

Thank you for updating.
I also added #1320 to the list.

[alex]

Updated list of outstanding PRs:

• python: add version() to get running version #1322
• abi3-py36 now passes tests #1320
• macros: rename crates for consistency #1317

[davidhewitt]

Thanks, I updated the top list!

[davidhewitt]

All outstanding PRs addressed! I'm going to open a release PR shortly...

[awestlake87]

Hey, just FYI I think this release broke my numpy dependency as a result of #1279:

    Checking numpy v0.12.1
error: no rules expected the token `,`
   --> /opt/.cargo/registry/src/github.com-1ecc6299db9ec823/numpy-0.12.1/src/array.rs:113:42
    |
113 | pyobject_native_type_named!(PyArray<T, D>, T, D);
    |                                          ^ no rules expected this token in macro call
error: cannot find macro `pyobject_native_type_convert` in this scope
   --> /opt/.cargo/registry/src/github.com-1ecc6299db9ec823/numpy-0.12.1/src/array.rs:104:1
    |
104 | pyobject_native_type_convert!(
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: a macro with a similar name exists: `pyobject_native_type_core`
    | 
   ::: /opt/.cargo/registry/src/github.com-1ecc6299db9ec823/pyo3-0.13.0/src/types/mod.rs:131:1
    |
131 | macro_rules! pyobject_native_type_core {
    | -------------------------------------- similarly named macro `pyobject_native_type_core` defined here
error: cannot find macro `pyobject_native_type_fmt` in this scope
   --> /opt/.cargo/registry/src/github.com-1ecc6299db9ec823/numpy-0.12.1/src/array.rs:114:1
    |
114 | pyobject_native_type_fmt!(PyArray<T, D>, T, D);
    | ^^^^^^^^^^^^^^^^^^^^^^^^ help: a macro with a similar name exists: `pyobject_native_type`
    | 
   ::: /opt/.cargo/registry/src/github.com-1ecc6299db9ec823/pyo3-0.13.0/src/types/mod.rs:157:1
    |
157 | macro_rules! pyobject_native_type {
    | --------------------------------- similarly named macro `pyobject_native_type` defined here
error: cannot find macro `pyobject_native_type_fmt` in this scope
   --> /opt/.cargo/registry/src/github.com-1ecc6299db9ec823/numpy-0.12.1/src/dtype.rs:35:1
    |
35  | pyobject_native_type_fmt!(PyArrayDescr);
    | ^^^^^^^^^^^^^^^^^^^^^^^^ help: a macro with a similar name exists: `pyobject_native_type`
    | 
   ::: /opt/.cargo/registry/src/github.com-1ecc6299db9ec823/pyo3-0.13.0/src/types/mod.rs:157:1
    |
157 | macro_rules! pyobject_native_type {
    | --------------------------------- similarly named macro `pyobject_native_type` defined here
    Checking futures v0.3.8
error[E0277]: the trait bound `PyArray<T, D>: PyTypeInfo` is not satisfied
   --> /opt/.cargo/registry/src/github.com-1ecc6299db9ec823/numpy-0.12.1/src/array.rs:101:19
    |
101 | unsafe impl<T, D> type_object::PyLayout<PyArray<T, D>> for npyffi::PyArrayObject {}
    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `PyTypeInfo` is not implemented for `PyArray<T, D>`
    | 
   ::: /opt/.cargo/registry/src/github.com-1ecc6299db9ec823/pyo3-0.13.0/src/type_object.rs:18:30
    |
18  | pub unsafe trait PyLayout<T: PyTypeInfo> {
    |                              ---------- required by this bound in `PyLayout`
error[E0277]: the trait bound `PyArray<T, D>: PyTypeInfo` is not satisfied
   --> /opt/.cargo/registry/src/github.com-1ecc6299db9ec823/numpy-0.12.1/src/array.rs:102:12
    |
102 | impl<T, D> type_object::PySizedLayout<PyArray<T, D>> for npyffi::PyArrayObject {}
    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `PyTypeInfo` is not implemented for `PyArray<T, D>`
    | 
   ::: /opt/.cargo/registry/src/github.com-1ecc6299db9ec823/pyo3-0.13.0/src/type_object.rs:30:28
    |
30  | pub trait PySizedLayout<T: PyTypeInfo>: PyLayout<T> + Sized {}
    |                            ---------- required by this bound in `PySizedLayout`
error: aborting due to 6 previous errors

Looks like this change was intentional, but it's causing issues for me because numpy v0.12.1 depends on pyo3 >=0.12 so it selects pyo3 v0.13 even though the current numpy release only works up to v0.12.4.

Are there any plans to release a v0.12.2 for numpy that caps the pyo3 version?

Update:
If anyone else is having this issue, adding the following patch fixed the issue for me:

[patch.crates-io]
numpy = { git = "https://github.com/awestlake87/rust-numpy", branch = "v0.12-fix" }

[davidhewitt]

Ah, that's unfortunate. I expect @kngwyu plans to release 0.13 numpy soon - we should probably push a 0.12.2 like you say that caps the version.

[davidhewitt]

I opened PyO3/rust-numpy#170 which will hopefully be released soon to fix the downstream issue.

[awestlake87]

Awesome, I appreciate it!