-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macros: rename crates for consistency #1317
Conversation
Oh yes please, this is much better. |
For historical context, I initially named it pyo3-derive-backend because I wanted to rename pyo3cls to pyo3-derive, but then didn't follow through because I realized you can't rename crates on crates.io |
Mmm I think I can manually release I chose |
I agree that the names are confusing (especially |
👍 I propose I merge this now and immediately release these crates with versions Then when |
7a854fa
to
d558449
Compare
@kngwyu unless you say otherwise I plan to merge this tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, please.
d558449
to
a689ab4
Compare
That's done, and all crates updated on https://crates.io/crates/pyo3cls |
This PR is a simple rename of
pyo3cls
topyo3-macros
andpyo3-derive-backend
topyo3-macros-backend
.I did this for a couple reasons:
pyo3-macros
matches nicely with themacros
feature.