Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macros: rename crates for consistency #1317

Merged
merged 1 commit into from
Dec 20, 2020

Conversation

davidhewitt
Copy link
Member

This PR is a simple rename of pyo3cls to pyo3-macros and pyo3-derive-backend to pyo3-macros-backend.

I did this for a couple reasons:

  • I think the original names are not very clear.
  • The name pyo3-macros matches nicely with the macros feature.

@birkenfeld
Copy link
Member

Oh yes please, this is much better.

@konstin
Copy link
Member

konstin commented Dec 13, 2020

For historical context, I initially named it pyo3-derive-backend because I wanted to rename pyo3cls to pyo3-derive, but then didn't follow through because I realized you can't rename crates on crates.io

@davidhewitt
Copy link
Member Author

Mmm I think I can manually release 0.12.5 versions of the old names, with READMEs saying to use the new ones.

I chose macros / macros-backend over derive / derive-backend because it's not just #[derive()] macros we provide.

@kngwyu
Copy link
Member

kngwyu commented Dec 13, 2020

I agree that the names are confusing (especially pyo3cls) and renaming is acceptable if we note that in README or so.

@davidhewitt
Copy link
Member Author

👍 I propose I merge this now and immediately release these crates with versions 0.13.0-alpha.1, so that they are available. I will also push 0.12.5 versions of pyo3cls and pyo3-derive-backend which note the change of name.

Then when 0.13 release comes the main pyo3 crate will be published to use these new crates.

@davidhewitt
Copy link
Member Author

@kngwyu unless you say otherwise I plan to merge this tomorrow.

Copy link
Member

@kngwyu kngwyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, please.

@davidhewitt davidhewitt merged commit a0588aa into PyO3:master Dec 20, 2020
@davidhewitt davidhewitt deleted the macros-crates branch December 20, 2020 09:54
@davidhewitt
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants