Improve default values for automatically-generated text_signature
#2863
Labels
Comments
This was referenced Mar 16, 2023
7 tasks
bors bot
added a commit
that referenced
this issue
Apr 12, 2023
3066: Improve default value for `None` in `text_signature` r=davidhewitt a=messense xref #2863 3098: readme: add new pyo3 article r=adamreichold a=davidhewitt With thanks to `@ohadravid` for the great piece! Co-authored-by: messense <messense@icloud.com> Co-authored-by: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
|
I've been reading up on issues related to #2454 (generating python interface / type stubs), and it looks like everything that was in scope for this issue is merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue is a follow-up to #2784 to remember to improve the formatting of default values in the generated
text_signature.Currently all default values are just rendered as
..., however Rust integer/boolean/string literals andNoneshould be easy enough to format a Python representation for.Support for more general Rust literals in the Python signature might need a larger refactoring to do more of the signature generation at runtime using traits.
Both of these will be easier after the signature code is simplified, i.e. once the deprecated
#[args]attribute is removed and maybe also #2703 is merged.The text was updated successfully, but these errors were encountered: