Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename PYTHON_SYS_EXECUTABLE to PYO3_PYTHON #1039

Merged
merged 1 commit into from
Aug 6, 2020
Merged

Rename PYTHON_SYS_EXECUTABLE to PYO3_PYTHON #1039

merged 1 commit into from
Aug 6, 2020

Conversation

davidhewitt
Copy link
Member

As suggested in #539 .

Once merged, I'll update setuptools-rust and maturin to output both environment variables for now, as a compatible way to manage the migration.

@davidhewitt
Copy link
Member Author

cc @konstin, who suggested originally. I'm also toying with the name PYO3_PYTHON.

kngwyu
kngwyu reviewed Jul 15, 2020
View reviewed changes
build.rs Outdated Show resolved Hide resolved
@davidhewitt davidhewitt changed the title Rename PYTHON_SYS_EXECUTABLE to PYO3_INTERPRETER Rename PYTHON_SYS_EXECUTABLE to PYO3_PYTHON Jul 15, 2020
@davidhewitt
Copy link
Member Author

Pushed the correction, and also renamed the variable to PYO3_PYTHON. I think the meaning is still clear, and it's shorter than PYO3_INTERPRETER.

If nobody has any objections to the new name I'll probably merge this on Sunday and write patches for setuptools-rust and maturin.

konstin
konstin approved these changes Jul 18, 2020
View reviewed changes
Copy link
Member

@konstin konstin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍, but this needs maturin and setuptools-rust releases before the next pyo3 release

@davidhewitt
Copy link
Member Author

👍 I plan to add patches to maturin and setuptools-rust before merging this PR!

@davidhewitt davidhewitt mentioned this pull request Jul 23, 2020
Merged
@davidhewitt davidhewitt mentioned this pull request Aug 6, 2020
Merged
@davidhewitt
Copy link
Member Author

I've now pushed patches both tools, so I've rebased this PR and will merge shortly.

@davidhewitt davidhewitt merged commit 11b6bac into PyO3:master Aug 6, 2020
@davidhewitt davidhewitt mentioned this pull request Aug 6, 2020
Closed
@davidhewitt davidhewitt linked an issue Aug 6, 2020 that may be closed by this pull request
Rename PYTHON_SYS_EXECUTABLE #539
Closed
@davidhewitt davidhewitt deleted the pyo3-interpreter branch August 10, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kngwyu kngwyu kngwyu left review comments

@konstin konstin konstin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename PYTHON_SYS_EXECUTABLE
3 participants
@davidhewitt @konstin @kngwyu