Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable &Self in #[pymethods] again #1071

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Enable &Self in #[pymethods] again #1071

merged 1 commit into from
Jul 28, 2020

Conversation

kngwyu
Copy link
Member

@kngwyu kngwyu commented Jul 28, 2020

Fixes #1070

davidhewitt
davidhewitt approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM, probably worth having a CHANGELOG entry?

@kngwyu kngwyu merged commit 51171f7 into PyO3:master Jul 28, 2020
@kngwyu kngwyu deleted the ref-self-regression branch July 28, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression using Self inside #[pymethods] arguments
2 participants
@kngwyu @davidhewitt