pymodule: remove call_function etc. #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @birkenfeld |
davidhewitt
force-pushed
the
no-pymodule-call-function
branch
from
8a22d5b
to
400fdb3
Compare
birkenfeld
approved these changes
Mar 13, 2021
|
Whoops, should not have been "approve" yet. |
davidhewitt
force-pushed
the
no-pymodule-call-function
branch
3 times, most recently
from
2297e43
to
e872635
Compare
davidhewitt
force-pushed
the
no-pymodule-call-function
branch
from
e872635
to
168946a
Compare
davidhewitt
force-pushed
the
no-pymodule-call-function
branch
from
168946a
to
b10cefd
Compare
messense
approved these changes
Mar 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So on
masterwe renamedPyModule::calltoPyModule::call_functionetc. in #1467But this is causing confusion to a user unfamiilar with the project in #1476 .
So I suggest we just remove
PyModule::call_functionand instead point users to use.getattr(...)?.call(). There's no optimization inPyModule::call_functionetc., so I think there's no reason we need to offer these APIs.I also deprecated
PyModule::getbecause it's just a dumb wrapper aroundPyAny::getattr, by the same logic.