ffi: prevent segfault with datetime bindings #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kngwyu
approved these changes
Apr 18, 2021
Comment on lines
+441
to
+445
| /// this is implemented as a wrapper which implements [`Deref`] to access a reference to a | ||
| /// [`PyDateTime_CAPI`] object. | ||
| /// | ||
| /// In the [`Deref`] implementation, if the underlying object has not yet been initialized, the GIL | ||
| /// will automatically be acquired and [`PyDateTime_IMPORT()`] called. |
There was a problem hiding this comment.
Yes, I checked in the docs locally🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a segfault achievable entirely in safe Rust:
The
Derefimplementation forPyDateTimeAPIcan call Python APIs, but before this PR it didn't check whether the GIL is actually held.