gil: try to initialize threads on Python 3.6 if possible #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
py36-threads-panic
branch
2 times, most recently
from
13b14a3
to
5a35a9d
Compare
andylokandy
reviewed
Sep 17, 2021
| @@ -52,10 +52,12 @@ pub(crate) fn gil_is_acquired() -> bool { | |||
| /// software). Support for this is tracked on the | |||
| /// [PyPy issue tracker](https://foss.heptapod.net/pypy/pypy/-/issues/3286). | |||
| /// | |||
| /// Python 3.6 only: If the Python interpreter is initialized but Python threading is not, this | |||
There was a problem hiding this comment.
Is it only for python3.6? I can't see that python36 is different from the previous versions from the FFI doc. But I haven't tested on python35 or earlier though.
There was a problem hiding this comment.
We don't support Python 3.5 or earlier, as their end of life date has already been reached.
Note also that we will stop supporting Python 3.6 next year: #1782
davidhewitt
force-pushed
the
py36-threads-panic
branch
from
5a35a9d
to
70d829d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1870