types: add PyTraceback #1977
Merged
types: add PyTraceback #1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is totally a bikeshed, but the |
davidhewitt
force-pushed
the
traceback-type
branch
from
15abdbb
to
3a2e096
Compare
|
👍 agreed, I was on the fence about this as I also thought |
|
I'll probably merge this early next week if there's no further concerns from anyone. |
davidhewitt
force-pushed
the
traceback-type
branch
from
3a2e096
to
88ca6bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
PyTracebacktype, with a.format()method to stringify the traceback object.Closes #592
This changes
PyErr::ptraceback()to returnOption<&PyTraceback>instead ofOption<&PyAny>, but I don't think this is breaking as&PyTracebackwill coerce to&PyAny.