frompyobject: fix from_py_with
ignored for transparent structs
#2440
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2396
Technically this is breaking, because previously the following enum would ignore the
from_py_with
annotation in the first variant. Now it will be used, so rather than only accepting positive integers the first variant will now accept anything with a__len__
. So there are silent changes of behaviour.However, on balance I would hope that this fixes any bugs users have rather than breaks stuff! I would defend fixing this is the correct choice.