Make is_instance() and is_subclass() take &PyAny
#2695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birkenfeld
force-pushed
the
isinstance
branch
from
eec701a
to
490d5e6
Compare
adamreichold
approved these changes
Oct 18, 2022
mejrs
approved these changes
Oct 18, 2022
Should be (mostly?) compatible since `&PyType` auto-derefs to `&PyAny`. Fixes #2694
birkenfeld
force-pushed
the
isinstance
branch
from
490d5e6
to
a001311
Compare
|
Agreed with all of the above. As a follow-up we could always add some examples to demonstrate that you'll usually call this with a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be (mostly?) compatible since
&PyTypeauto-derefs to&PyAny.Fixes #2694