normalize exception in PyErr::matches and PyErr::is_instance
#3313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
commented
Jul 11, 2023
davidhewitt
changed the title
PyErr::matches and PyErr::get_typePyErr::matches and PyErr::is_instance
davidhewitt
force-pushed
the
unnormalized-err-type
branch
from
de5644d
to
8909bdd
Compare
davidhewitt
force-pushed
the
unnormalized-err-type
branch
from
ac22ff6
to
eb8c23e
Compare
davidhewitt
force-pushed
the
unnormalized-err-type
branch
from
eb8c23e
to
f39dd52
Compare
|
I've corrected the header and changelog entry, and pushed a separate commit to action the removal of "normalization" as a term from the PyErr docs. |
adamreichold
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off from #3306
This fixes a case where
PyErr::matchesandPyErr::is_instancecould return results inconsistent withPyErr::get_typedue to the first two methods not ensuring the exception was normalised.