add as_ptr and into_ptr inherent methods #3359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
py-pointer-methods
branch
2 times, most recently
from
d4028bc
to
9274667
Compare
alex
reviewed
Jul 30, 2023
davidhewitt
force-pushed
the
py-pointer-methods
branch
from
9274667
to
94767b0
Compare
davidhewitt
force-pushed
the
py-pointer-methods
branch
2 times, most recently
from
ea52298
to
849d3c2
Compare
davidhewitt
force-pushed
the
py-pointer-methods
branch
from
849d3c2
to
4340c2c
Compare
davidhewitt
force-pushed
the
py-pointer-methods
branch
from
4340c2c
to
64adab1
Compare
adamreichold
approved these changes
Aug 11, 2023
alex
added a commit
to alex/pyo3
that referenced
this pull request
Aug 14, 2023
it wasn't used in any public APIs following PyO3#3359
Merged
alex
added a commit
to alex/pyo3
that referenced
this pull request
Aug 14, 2023
it wasn't used in any public APIs following PyO3#3359
alex
added a commit
to alex/pyo3
that referenced
this pull request
Aug 14, 2023
it wasn't used in any public APIs following PyO3#3359
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #3325.
Adds
as_ptrandinto_ptrmethods toPy,PyAny,PyRef, andPyRefMut.Between these four types, we can bin off a significant amount of PyO3's internal usage of
AsPyPointerandIntoPyPointer, and this is probably also true for downstream.Future PRs can figure out the remaining APIs which interact with these traits.