Fix memory leak in PyTypeBuilder::build
#3401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messense
force-pushed
the
fix-issue-3400
branch
2 times, most recently
from
00d3507
to
bbe7b35
Compare
davidhewitt
requested changes
Aug 18, 2023
There was a problem hiding this comment.
It looks like this is only correct since Python 3.11:
https://docs.python.org/3/whatsnew/changelog.html#id144
So we'll need to decide to do this based on the Python version at runtime. For non-abi3 that's easy, we use cfg, for abi3 we need to detect sys.version_info - see bpo_35810_workaround in pyclass.rs for an example of how to do this.
messense
force-pushed
the
fix-issue-3400
branch
from
bbe7b35
to
475bb0f
Compare
messense
force-pushed
the
fix-issue-3400
branch
from
475bb0f
to
2dc1e9a
Compare
|
FYI, the C API changelog entry is a bit wrong, it's not |
davidhewitt
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3400