-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: drop futures_util dependency #3608
Conversation
CodSpeed Performance ReportMerging #3608 will degrade performances by 25.3%Comparing Summary
Benchmarks breakdown
|
27f63b0
to
c474531
Compare
1731c6d
to
b86bce4
Compare
thank you! |
7621d30
to
d48c8e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second commit looks good to me. The Clippy issues seem to stem from #3599
It seems to me that it's not a clippy issue but a benchmark issue (as written in the email I received). Clippy jobs are just cancelled because of benchmark failure (same in #3599).
I cannot reproduce it on my computer. |
I think the 🤦♂️ emoji was invented for this moment... I've updated both PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning up the dependency! Based on the codecov report I guess we don't have a test for the panic-inside-future case? Maybe check and if needed add one please?
After that, good to merge IMO 👍
Should be better now, but there was a Codecov issue in the CI:
@davidhewitt Do you want to relaunch coverage job? |
src/coroutine.rs
Outdated
@@ -1,21 +1,19 @@ | |||
//! Python coroutine implementation, used notably when wrapping `async fn` | |||
//! with `#[pyfunction]`/`#[pymethods]`. | |||
use std::task::Waker; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed this only now, but I think this should be sorted into the use tree below with Content
and Poll
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will do the modification.
However, maybe we should consider using nightly rustfmt someday. For example, in all my projects, I add the following .rustfmt.toml
:
group_imports = "StdExternalCrate"
imports_granularity = "Crate"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My concern would be that this makes it harder for contributors to use a stable toolchain if it's trying to conflict with the nightly rustfmt settings, but I haven't explored this. We could certainly consider it.
Previous pipeline showed that some tests was not deterministic, so I replace 1s sleeps by 999s. |
See #1632 (comment)
Draft based on #3599
@davidhewitt Skip changelog?