Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a definite version specification when depending on pyo3-build-config. #3721

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Use a definite version specification when depending on pyo3-build-config. #3721

merged 1 commit into from
Jan 2, 2024

Conversation

adamreichold
Copy link
Member

@adamreichold adamreichold commented Jan 2, 2024 •
edited
Loading

We already do this for other internal pyo3-* dependencies and it seems prudent to apply this to pyo3-build-config as well.

Closes #3719

@adamreichold
Use a definite version specification when depending on pyo3-build-con…
0328583 
…fig.

We already do this for other internal pyo3-* dependencies and it seems prudent
to apply this to pyo3-build-config as well.
@adamreichold adamreichold added the CI-skip-changelog Skip checking changelog entry label Jan 2, 2024
@adamreichold adamreichold mentioned this pull request Jan 2, 2024
Merged
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 2, 2024

CodSpeed Performance Report

Merging #3721 will improve performances by 11.66%

Comparing fix-build-config-dep (0328583) with main (5ea2e5c)

Summary

⚡ 1 improvements
✅ 77 untouched benchmarks

Benchmarks breakdown

Benchmark main fix-build-config-dep Change
⚡ extract_int_downcast_fail 266.1 ns 238.3 ns +11.66%

davidhewitt
davidhewitt approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, shame it's too late to apply this to 0.20.0. I'm tempted to backport for 0.20.2 anyway.

@davidhewitt davidhewitt added this pull request to the merge queue Jan 2, 2024
Merged via the queue into main with commit febf7a0 Jan 2, 2024
39 checks passed
@davidhewitt davidhewitt deleted the fix-build-config-dep branch January 2, 2024 15:05
@davidhewitt davidhewitt mentioned this pull request Jan 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible breaking change in pyo3-build-config from 0.20.0 0.20.1?
2 participants
@adamreichold @davidhewitt