deprecate gil-refs in from_py_with (Part 2)
#3972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 tasks
davidhewitt
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Brilliant, thanks!
I think the last remaining thing is #3847, which I'm trying to rebase now. Then perhaps, apart from another read of the docs, it's time for 0.21 final...
| &self, | ||
| struct_fields: &[NamedStructField<'_>], | ||
| ctx: &Ctx, | ||
| ) -> (TokenStream, TokenStream) { |
There was a problem hiding this comment.
I sort of wondered whether it would be nicer to have a struct DeriveOutput { ... } just to name the two TokenStream elements, but as this is all quite temporary and the pattern is quite consistent I can live without that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows up on #3967 in deprecating the use of gil-refs in
from_py_with.This PR adds the implementation for
#[derive(FromPyObject)].