Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix declarative module compile error with create_exception! #4086

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

Icxolu
Copy link
Contributor

@Icxolu Icxolu commented Apr 16, 2024

Fixes a compile error when exporting an exception created with create_exception! living in a different Rust module using the declarative-module feature.

Fixes #4036

@adamreichold adamreichold added this pull request to the merge queue Apr 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2024
@Icxolu Icxolu added this pull request to the merge queue Apr 16, 2024
Merged via the queue into PyO3:main with commit 03f59ea Apr 16, 2024
43 checks passed
@Icxolu Icxolu deleted the fix-4036 branch April 16, 2024 20:51
@nickdrozd
Copy link

Is it possible to do a 0.21.3 release to include this? I'm still stuck on 0.21.0.

@davidhewitt
Copy link
Member

I think there will be a 0.21.3 release but there's at least two other bugs we're still fixing before we ship it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile errors with 0.21.1
4 participants