Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update dependencies #4617

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Conversation

adamcavendish
Copy link
Contributor

@adamcavendish adamcavendish commented Oct 13, 2024

deps: update dependencies

  • eyre: 0.4 => 0.6.8
  • hashbrown: 0.9 => 0.14.5
  • indexmap: 1.6 => 2.5.0
  • num-complex: 0.2 => 0.4.6
  • chrono-tz: 0.6 => 0.10

Eyre min-version is limited to 0.6.8 to be compatible with MSRV 1.63
Hashbrown min-version is limited to 0.14.5: rust-lang/hashbrown#574
Indexmap min-version is limited to 2.5.0 to be compatible with hashbrown 0.14.5

@adamcavendish adamcavendish force-pushed the 4614-lib-version-bump branch 2 times, most recently from 9c69c37 to c7e9d3e Compare October 13, 2024 09:27
@adamcavendish adamcavendish marked this pull request as ready for review October 13, 2024 09:27
@adamcavendish
Copy link
Contributor Author

Hi @davidhewitt , the eyre package starts to have MSRV since v0.6.9, which is 1.65.0.

Reference: https://crates.io/crates/eyre/versions

However, PyO3 has MSRV 1.63. What do you think I should do with eyre?

  • Leave it on the original version
  • Update PyO3 MSRV to 1.65.0

@davidhewitt
Copy link
Member

Thanks for this, we should keep MSRV at 1.63. So we should keep eyre to >= 0.6.8. There might be similar cases for the other packages?

@kahojyun
Copy link

https://lib.rs is useful for choosing minimum versions. For example, we can view MSRV and download counts of eyre on https://lib.rs/crates/eyre/versions and https://lib.rs/crates/eyre/rev.

@adamcavendish adamcavendish force-pushed the 4614-lib-version-bump branch 4 times, most recently from 53c88f4 to a1c7213 Compare October 13, 2024 14:53
@adamcavendish
Copy link
Contributor Author

As discussed, the dependencies have been limited to:

Note that not only ">=" have been updated, but "<" are also updated to address the limitations.

@davidhewitt
Copy link
Member

Actually, I think it's probably better to let the upper bounds be the latest versions of the crates. As long as the lower bounds can build on MSRV and we haven't dropped extremely popular versions of the crates, it's best for the ecosystem if we support a wide range. Sorry to have not been clearer about the upper bounds!

@davidhewitt
Copy link
Member

I.e. upper bounds should ideally be the latest major versions unless there's a very good reason not to support them. I think the upper bounds we had previously were probably fine?

@adamcavendish
Copy link
Contributor Author

I.e. upper bounds should ideally be the latest major versions unless there's a very good reason not to support them. I think the upper bounds we had previously were probably fine?

The upper bounds are reset.

@adamcavendish
Copy link
Contributor Author

@davidhewitt feel free to merge if you consider it fine. Or happy to make changes if any comments.

Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me! Sorry for the delay, long week 😩

@davidhewitt davidhewitt added this pull request to the merge queue Oct 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 18, 2024
@davidhewitt davidhewitt added this pull request to the merge queue Oct 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 18, 2024
Cargo.toml Outdated Show resolved Hide resolved
- eyre: 0.4 => 0.6.8
- hashbrown: 0.9 => 0.14.5
- indexmap: 1.6 => 2.5.0
- num-complex: 0.2 => 0.4.6
- chrono-tz: 0.6 => 0.10

Eyre min-version is limited to 0.6.8 to be compatible with MSRV 1.63
Hashbrown min-version is limited to 0.14.5:
  rust-lang/hashbrown#574
Indexmap min-version is limited to 2.5.0 to be compatible with hashbrown 0.14.5
@davidhewitt davidhewitt added this pull request to the merge queue Oct 20, 2024
Merged via the queue into PyO3:main with commit 7c39f1c Oct 20, 2024
77 of 78 checks passed
@adamcavendish adamcavendish deleted the 4614-lib-version-bump branch October 21, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants