Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 0.22.6 #4684

Merged
merged 3 commits into from
Nov 5, 2024
Merged

release: 0.22.6 #4684

merged 3 commits into from
Nov 5, 2024

Conversation

davidhewitt
Copy link
Member

@davidhewitt davidhewitt commented Nov 5, 2024

This fixes the detection of freethreaded Python on the 0.22 release branch, and bumps the version to 0.22.6 for shipping immediately.

Given 0.23 is days away, hopefully this is the last 0.22 patch fix (though I said that last time, and maybe the time before).

@ngoldbaum I tested this locally, would you mind pulling and also checking locally? I think if we are both happy this works, that's good enough given the branch is likely to remain frozen hereafter.

Closes #4682

@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Nov 5, 2024
Copy link

codspeed-hq bot commented Nov 5, 2024

CodSpeed Performance Report

Merging #4684 will degrade performances by 10.34%

Comparing release-0.22.6 (3da55dc) with release-0.22 (ec6d4f8)

Summary

⚡ 4 improvements
❌ 1 regressions
✅ 63 untouched benchmarks

🆕 6 new benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark release-0.22 release-0.22.6 Change
🆕 call N/A 620.7 µs N/A
🆕 call_1 N/A 258.7 µs N/A
🆕 call_method N/A 1.3 ms N/A
🆕 call_method_1 N/A 656 µs N/A
🆕 call_method_one_arg N/A 626 µs N/A
🆕 call_one_arg N/A 232.5 µs N/A
iter_tuple 5.3 ms 5.9 ms -10.34%
test_args_kwargs_py 20.9 µs 18.5 µs +13.1%
test_args_kwargs_rs 15.4 µs 13.5 µs +13.97%
test_simple_kwargs_py 21.8 µs 19.8 µs +10.29%
test_simple_kwargs_rs 20.6 µs 18.2 µs +13.11%

@ngoldbaum
Copy link
Contributor

This works for me locally. Just pushed a fix for the test failures on CI.

@davidhewitt
Copy link
Member Author

Thanks; I'm not worried about the beta clippy warnings; they're just new lints hitting code which is unchanged from 0.22.5. I will rebase / merge & release.

@ngoldbaum
Copy link
Contributor

Thanks; I'm not worried about the beta clippy warnings; they're just new lints hitting code which is unchanged from 0.22.5. I will rebase / merge & release.

Ah sorry didn't mean to step on you!

@davidhewitt davidhewitt merged commit c000ab9 into release-0.22 Nov 5, 2024
5 checks passed
@davidhewitt davidhewitt deleted the release-0.22.6 branch November 5, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants