Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build script always using python3 in OSX builds #604

Merged
merged 2 commits into from
Sep 15, 2019
Merged

Fix build script always using python3 in OSX builds #604

merged 2 commits into from
Sep 15, 2019

Conversation

althonos
Copy link
Member

Hi!

I noticed that when compiling pyo3 on OSX for a non-standard Python interpreter (such as PyPy), the build script would at some point assume python or python3 to be the name of the interpreter, despite PYTHON_SYS_EXECUTABLE being set. This was caused by get_macos_linkmodel using the default PYTHON_INTERPRETER eventually.

Thank you for contributing to pyo3!

  • Run cargo fmt (This is checked by travis ci) ✅
  • Run cargo clippy and check there are no hard errors (There are a bunch of existing warnings; This is also checked by travis) ✅
  • If applicable, add an entry in the changelog. ✅

@kngwyu
Copy link
Member

kngwyu commented Sep 15, 2019

the build script would at some point assume python or python3 to be the name of the interpreter, despite PYTHON_SYS_EXECUTABLE being set.

Ah, it's because of #596.
Sorry, I overlooked the problem when reviewing, and thank you for fixing it!

@kngwyu kngwyu merged commit ce4b3a5 into PyO3:master Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants