Updated minimum Rust version #131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! We would need to wait for PyO3 0.11.0 to be released PyO3/pyo3#989 before updating the readme. It would be good to try building with PyO3 master in CI though and check if anything needs to be updated. |
|
Oh didn't see the PR, I'll add it to the blocking list |
|
Thanks! |
|
Also, it's better if we have minimum-rustc bagde |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if
Rust 1.39+,Rust >=1.39or something likeminimum...is needed.See PyO3/pyo3#5 (comment).
PyO3/pyo3@7075827 (PyO3/pyo3#989) is blocking this from being merged.