Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

constraints: sanitize infinity values #370

Merged
merged 2 commits into from
Oct 31, 2024
Merged

constraints: sanitize infinity values #370

merged 2 commits into from
Oct 31, 2024

Conversation

FabianHofmann
Copy link
Collaborator

closes #369 #368 #154 #362

@FabianHofmann FabianHofmann requested a review from lkstrp October 31, 2024 13:26
@FabianHofmann
Copy link
Collaborator Author

@lkstrp with this implementation we do two things on top of #369

  1. avoid large bounds in rhs by simply skipping unbounded constraints
  2. check infeasible constraints of the form >= inf and <= -inf

lkstrp
lkstrp approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@lkstrp lkstrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I agree, this is much cleaner

linopy/constraints.py Outdated Show resolved Hide resolved
@FabianHofmann FabianHofmann merged commit 3d0275d into master Oct 31, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkstrp lkstrp lkstrp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FabianHofmann @lkstrp