Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding overnight costs in modify_prenetwork #181

Merged
merged 5 commits into from
Sep 6, 2024
Merged

Conversation

toniseibold
Copy link
Contributor

@toniseibold toniseibold commented Sep 4, 2024

Overnight costs were added to enable an easier reporting of investment costs.
They are already added in prepare_sector_network but since we change/add technologies in the rule modify_prenetwork, I added those there as well.

Only three technologies were missing:

  • "DE oil Store"
  • "DE methanol Store" (parameters of both are now passed over by referencing the European Store)
  • Hydrogen retrofitted gas plants

Before asking for a review for this PR make sure to complete the following checklist:

  • Workflow with target rule ariadne_all completes without errors
    no - however this is not affected by this PR
  • The logic of export_ariadne_variables has been adapted to the changes
    not applicable
  • One or several figures that validate the changes in the PR have been posted as a comment
    not applicable
  • A brief description of the changes has been added to Changelog.md
    not necessary
  • The latest main has been merged into the PR
  • The config has a new prefix of the format YYYYMMDDdescriptive_title

Copy link

github-actions bot commented Sep 4, 2024

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

❗ Run failed!

Download 'logs' artifact to see more details.

  • main passed! ✅
  • bug_fix_investment_costs failed in: build_transmission_projects

Comparing bug_fix_investment_costs (3671248) with main (a4c3104).
Branch is 8 commits ahead and 1 commits behind.
Last updated on 2024-09-06 19:12:46 CEST.

@toniseibold toniseibold requested a review from lindnemi September 4, 2024 15:12
@toniseibold toniseibold marked this pull request as ready for review September 4, 2024 15:12
@lindnemi
Copy link
Collaborator

lindnemi commented Sep 5, 2024

Almost there, please add the scaling of overnight_costs for retrofitted CHP H2 plants as well, then it's good to be merged

@toniseibold
Copy link
Contributor Author

Thanks for pointing that out - added those as well :)

@lindnemi lindnemi merged commit 6293d3b into main Sep 6, 2024
1 of 2 checks passed
toniseibold added a commit that referenced this pull request Sep 23, 2024
* robustely adding parameters for DE meoh and oil stores

* adjust overnight costs for retrofitted gas plants

* satisfy checklist and rename prefix

* adding overnight costs to chps as well

---------

Co-authored-by: Michael Lindner <michaellindner@posteo.de>
@toniseibold toniseibold deleted the bug_fix_investment_costs branch October 25, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants