Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Italy #183

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Adding Italy #183

merged 3 commits into from
Sep 6, 2024

Conversation

toniseibold
Copy link
Contributor

@toniseibold toniseibold commented Sep 6, 2024

Closing #176

Please note that I increased the number of nodes. So far 22 nodes translated to 8 nodes for Germany and the rest for the Stromnachbarn.
With adding Italy (and Spain) a total of 5 nodes is needed to model those countries. Italy needs 3 nodes (mainland, Sardinia, Corsica) - Spain needs 2 nodes (mainland, Mallorca).

Workflow runs smoothly and the basenetwork elec_s_27.nc looks like this:
image

Before asking for a review for this PR make sure to complete the following checklist:

  • Workflow with target rule ariadne_all completes without errors
  • The logic of export_ariadne_variables has been adapted to the changes
  • One or several figures that validate the changes in the PR have been posted as a comment
  • A brief description of the changes has been added to Changelog.md
  • The latest main has been merged into the PR
  • The config has a new prefix of the format YYYYMMDDdescriptive_title

@toniseibold toniseibold requested a review from lindnemi September 6, 2024 07:59
@toniseibold toniseibold marked this pull request as ready for review September 6, 2024 08:01
@lindnemi lindnemi merged commit cb041ab into main Sep 6, 2024
2 checks passed
Copy link

github-actions bot commented Sep 6, 2024

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

❗ Run failed!

Download 'logs' artifact to see more details.

  • main passed! ✅
  • add_italy failed in: build_transmission_projects

Comparing add_italy (3671248) with main (a4c3104).
Branch is 8 commits ahead and 1 commits behind.
Last updated on 2024-09-06 19:12:18 CEST.

toniseibold added a commit that referenced this pull request Sep 23, 2024
* config for 27 nodes adding Italy

* document changes in log

---------

Co-authored-by: Michael Lindner <michaellindner@posteo.de>
@toniseibold toniseibold deleted the add_italy branch October 25, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants