Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

biogas potential overestimated with myopic #504

Closed
martavp opened this issue Mar 10, 2022 · 7 comments
Closed

biogas potential overestimated with myopic #504

martavp opened this issue Mar 10, 2022 · 7 comments

Comments

@martavp
Copy link
Member

martavp commented Mar 10, 2022

There is a bug for the biogas potential, one store with 345TWh is added in every time step, i.e. 'EU biogas-2020', EU biogas-2025' This overestimates the biogas potential. It can be easily fixed by checking if the EU biogas store exits before adding it .

This is also an issue for the solid biomass potential

@ebbekyhl
Copy link
Contributor

One quick fix to this issue: PyPSA/pypsa-eur-sec#231 (Set all stores from previous years to zero)

@ebbekyhl
Copy link
Contributor

ebbekyhl commented Mar 17, 2022

This is only an issue in PyPSA-Eur-Sec 0.6.0 when doing pathway optimization

@nworbmot
Copy link
Member

Can we find out which commit caused this bug? Not to assign blame, but just so we can check there were no further bugs introduced.

@lisazeyen
Copy link
Contributor

I am having a look at the PR and can have a look at the commits as well.

@lisazeyen
Copy link
Contributor

The error was introduced by the new default values (PyPSA release 0.18) where the lifetime has a default value np.inf (previous default np.nan). When filtering which assets should be duplicated for each investment period in function add_build_year_to_new_assets (see here) it does not filter out anymore the biogas/biomass stores.
It should be resolved in PR PyPSA/pypsa-eur-sec#217

@lisazeyen
Copy link
Contributor

resolved in PyPSA/pypsa-eur-sec#217

1 similar comment
@lisazeyen
Copy link
Contributor

resolved in PyPSA/pypsa-eur-sec#217

@fneum fneum transferred this issue from PyPSA/pypsa-eur-sec Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants