Myopic fix

[lisazeyen]

this PR should resolve some conflicts with the latest changes if running the model with myopic foresight, namely:

• adjust functions to work with the new default lifetime np.inf (instead of previous NaN)
• add electricity grid connection costs to renewables solar and onwind, take the right capital costs if solar is splited into rooftop and utility
• general update of the mocksnakemake for testing
• use the define_spatial function also for other conventional carriers
• add lifetime for H2 Stores
• enable to run the myopic code with a spatial resolved gas network, which means:
  • adding existing components to the right buses ("EU gas" or all buses with carrier gas)
  • avoid doubling of the existing gas network in module add_brownfield
  • adjusting the retrofitting pipe line constraint to work with multiple build years of the pipe
  • adjusting the plot_h2 function to work with multiple build years of the pipe lines

[fneum]

Thanks @lisazeyen. Looks mostly good to me. Had a few style ideas.

[lisazeyen]

This PR should resolve the problem with e.g. the biomass/biogas potential described in issue PyPSA/pypsa-eur#504 and closes PR #231
The error was introduced by the new default values (PyPSA release 0.18) where the lifetime has a default value np.inf (previous default np.nan). When filtering which assets should be duplicated for each investment period in function add_build_year_to_new_assets (see here) it does not filter out anymore the biogas/biomass stores.

[fneum]

Great! It's much clearer now. I only had a few style suggestions.

[lisazeyen]

Hi Fabian, I have included you code style suggestions. Do you think the way the gas network is treated now here is better than before? I initially added the first part to avoid duplicating the capacity of the existing gas network for each investment period. I think with the retrofitting of the gas pipes it does make sense. Without the option to retrofit the gas pipelines their capacity can be expanded further than the current capacity. I guess it is better to keep the gas pipes from the previous investment period with their optimized capacity and with p_nom_extendable=False and to set the capacity of all the "new build" gas pipes of the current investment period to p_nom=0

[lisazeyen]

The latest commits include a simplification of the retrofitting gas pipe constraint and sets the minimum capacity of AC and DC lines to the optimised capacity of the previous year. This should close PyPSA/pypsa-eur#501