Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix offshore wind capacity by adding it as offwind-AC #1089

Merged
merged 6 commits into from
Jun 4, 2024
Merged

Fix offshore wind capacity by adding it as offwind-AC #1089

merged 6 commits into from
Jun 4, 2024

Conversation

toniseibold
Copy link
Contributor

@toniseibold toniseibold commented Jun 4, 2024 •
edited
Loading

Closes #1088

Changes proposed in this Pull Request

Adding offshore capacity from IRENA as offshore-ac.

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

@toniseibold toniseibold requested a review from fneum June 4, 2024 12:02
@toniseibold toniseibold marked this pull request as ready for review June 4, 2024 12:02
@toniseibold toniseibold changed the title Fix offshore wind capacity by adding it as offwind-DC Fix offshore wind capacity by adding it as offwind-AC Jun 4, 2024
fneum
fneum requested changes Jun 4, 2024
View reviewed changes
Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just double-check the .split() suggestion and merge at will.

scripts/add_existing_baseyear.py Outdated Show resolved Hide resolved
scripts/add_existing_baseyear.py Outdated Show resolved Hide resolved
toniseibold and others added 3 commits June 4, 2024 16:19
@toniseibold @fneum
Update scripts/add_existing_baseyear.py
5051eae 
Co-authored-by: Fabian Neumann <fabian.neumann@outlook.de>
@toniseibold @fneum
Update scripts/add_existing_baseyear.py
ae2dc6f 
Co-authored-by: Fabian Neumann <fabian.neumann@outlook.de>
@toniseibold
bug fixing
f373352
@toniseibold toniseibold merged commit d62e959 into master Jun 4, 2024
6 checks passed
@toniseibold toniseibold deleted the offwind_capacity_fix branch June 4, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fneum fneum fneum requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Offshore capacity
2 participants
@toniseibold @fneum