Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FT and electrolysis waste heat for DH as float #1141

Merged
merged 5 commits into from
Jul 11, 2024
Merged

Conversation

cpschau
Copy link
Contributor

@cpschau cpschau commented Jul 9, 2024

The waste heat of Fischer-Tropsch synthesis and electrolyzers is dominating the urban central heat mix for planning horizons > 2030 (PyPSA/pypsa-ariadne#114). This PR allows for the multiplication of the link efficiency by a float in order to make more conservative assumptions regarding the usage of this waste heat.

@cpschau cpschau changed the title FT and electrolyis waste heat for DH as float FT and electrolysis waste heat for DH as float Jul 9, 2024
@lindnemi
Copy link
Contributor

lindnemi commented Jul 9, 2024

Thanks for getting started with this so quickly. A few minor points

  • Why did you settle for 0.2? Tom suggested 0.25-0.5 as far as i remember.
  • A release_note might be helpful
  • Methanolisation, Sabatier and H2 Fuel Cells also connect to central heat and should probably get their own multipliers

@cpschau cpschau requested a review from lindnemi July 11, 2024 09:08
Copy link
Contributor

@lindnemi lindnemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I already merged it into ariadne2 and it seems to do it's job. 👏

@lindnemi lindnemi merged commit 4dd0bb8 into master Jul 11, 2024
5 of 6 checks passed
lindnemi added a commit that referenced this pull request Jul 11, 2024
Follow-up: Adjusted release note of #1141
@fneum
Copy link
Member

fneum commented Jul 11, 2024

Great! Just leaving a note on backwards compatibility for next time: The change in the config file was purely stylistic but leads to old configs not being compatible with the new version.

@lindnemi
Copy link
Contributor

lindnemi commented Jul 11, 2024

ups, i suggest the new style and didn't notice that it changes the config 😬 should we revert to the old config style before the next release?

@fneum
Copy link
Member

fneum commented Jul 12, 2024

Yes, let's do it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants