-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Approximate district heating COPs via Jensen et al. 2018 #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…individual_heating
… et al. and values from Pieper et al.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…to update-district-heating-cops
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@fneum This is good to go from my side. The first CI build is failing. Any idea why? |
…SA/pypsa-eur into update-district-heating-cops
for more information, see https://pre-commit.ci
…SA/pypsa-eur into update-district-heating-cops
for more information, see https://pre-commit.ci
…SA/pypsa-eur into update-district-heating-cops
Ready for re-review.
|
|
lisazeyen
approved these changes
Aug 7, 2024
@amosschle really nice, code looks super clean and well documented! We should use the same approach for other sectors as well. |
Note for future reference:
|
fneum
reviewed
Aug 7, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #857.
with respect to central heating.
Changes proposed in this Pull Request
build_cop_profiles
builds separate heat pump COPs for decentral and central heating.Checklist
envs/environment.yaml
.config.default.yaml
.doc/configtables/*.csv
.doc/release_notes.rst
is added.Jupyter notebook and config files are attached below (
.txt
must be changed accordingly).Impact on results
A quick test run (DE only, 2 nodes, 2050) suggests the resulting COPs after changing the approximation method and forward/return temperatures in district heating to be somewhat similar as before.
Updating only the approximation method but setting an (unrealistic) forward temperature of 55C (the current default) results in significantly higher central heat pump COPs and higher heat pump investments.
jupyter_notebook.txt
config.txt
scenarios.txt