Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning for 'closed' with pandas 1.4 #323

Merged
merged 10 commits into from
Feb 11, 2023

Conversation

euronion
Copy link
Contributor

@euronion euronion commented Mar 4, 2022

DNMY. Merge with next-next release. Will force pandas>=1.4.

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml, config.tutorial.yaml, and test/config.test1.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes.

@euronion euronion added this to the Release 0.6 milestone Mar 4, 2022
@euronion
Copy link
Contributor Author

euronion commented Mar 4, 2022

PR in principle ready, marked as "Draft" as to not accidentally merge it with the upcoming release. Intended to be merged with the next next release.

@fneum fneum mentioned this pull request May 1, 2022
6 tasks
@FabianHofmann
Copy link
Contributor

@euronion would now be the time for merging this?

@FabianHofmann FabianHofmann changed the title [DNMY] Fix deprecation warning for 'closed' with pandas 1.4 Fix deprecation warning for 'closed' with pandas 1.4 Feb 8, 2023
@FabianHofmann FabianHofmann marked this pull request as ready for review February 8, 2023 19:13
@FabianHofmann FabianHofmann requested a review from fneum February 8, 2023 19:50
@fneum
Copy link
Member

fneum commented Feb 11, 2023

Pandas 1.4 is more than one year old, so I guess yes.

@fneum fneum merged commit 8d072a0 into master Feb 11, 2023
@fneum fneum deleted the fix/deprecation-warning-pandas-1.4 branch February 11, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants