Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lift rasterio restriction to allow atlite 0.2.9 #417

Merged
merged 3 commits into from
Sep 19, 2022
Merged

Conversation

fneum
Copy link
Member

@fneum fneum commented Sep 16, 2022

atlite 0.2.9 requires minimum rasterio 1.3, so with current environment restrictions never installed

rasterio 1.2.10 should still be forbidden, in case earlier atlite versions are installed

@fneum fneum requested a review from pz-max September 16, 2022 14:16
@fneum fneum mentioned this pull request Sep 16, 2022
3 tasks
@FabianHofmann FabianHofmann self-requested a review September 16, 2022 14:50
@FabianHofmann
Copy link
Contributor

you have a clue why windows CI does not want to do its job?

@fneum
Copy link
Member Author

fneum commented Sep 16, 2022

I think it's because I lifted the ipopt version restriction, where Win has problems with finding executables of newer ipopt versions.

On the other hand Ubuntu had troubles now with the older ipopt versions.

So, I think the solution would be to make the appendix to the environment.yaml in the Github Action dependent on matrix.os. What do you think?

@FabianHofmann FabianHofmann merged commit 85b1f96 into master Sep 19, 2022
@FabianHofmann FabianHofmann deleted the rasterio-1.3 branch September 19, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants