Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi horizon #637

Merged
merged 77 commits into from
Oct 5, 2023
Merged

Multi horizon #637

merged 77 commits into from
Oct 5, 2023

Conversation

lisazeyen
Copy link
Contributor

@lisazeyen lisazeyen commented Apr 6, 2023

Closes # (if applicable).

Changes proposed in this Pull Request

This PR should include perfect foresight for pathway optimisation.

Open ToDos:

  • add extra_functionalities for perfect foresight
  • min_part_load for methanolisation for shipping and Fischer-Tropsch leads to infeasibilities
  • must run condition for existing gas boilers to avoid massive back up energy, add option to retrofit them to h2 boilers
  • transmission expansion
  • carbon budget constraint
  • option for max growth for certain carriers

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

@fneum fneum mentioned this pull request Jul 26, 2023
@lisazeyen lisazeyen marked this pull request as ready for review August 30, 2023 10:07
@lisazeyen
Copy link
Contributor Author

@FabianHofmann Some points still can be improved for the multi-decade optimisation, but I would be happy to pull a first beta version into the master branch and then work on the single features in separate smaller PR.

@lisazeyen
Copy link
Contributor Author

@FabianHofmann CI should run through once PyPSA/PyPSA#721 is in. There is a problem if the optimisation is multi-decade and the list of extendable lines or DC links is empty when selecting the active assets of an empty list.

@lisazeyen
Copy link
Contributor Author

@FabianHofmann, what do you think, can we merge?

Copy link
Contributor

@FabianHofmann FabianHofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be much in favour to merge it. Here some last remaining comments and the CI should run through. Otherwise, it looks great!

scripts/plot_summary.py Outdated Show resolved Hide resolved
scripts/solve_network.py Show resolved Hide resolved
scripts/solve_network.py Outdated Show resolved Hide resolved
scripts/solve_network.py Show resolved Hide resolved
config/config.perfect.yaml Show resolved Hide resolved
@lisazeyen
Copy link
Contributor Author

lisazeyen commented Oct 4, 2023

@FabianHofmann thanks for your feedack!
CI is running through with the latest PyPSA Version, only the building of the documentation fails. I addressed your points above

@FabianHofmann
Copy link
Contributor

Nice, let's go for it!

@FabianHofmann FabianHofmann merged commit 9cc6761 into master Oct 5, 2023
3 checks passed
@FabianHofmann FabianHofmann deleted the multi-horizon branch October 5, 2023 10:34
fneum added a commit that referenced this pull request Oct 18, 2023
follow-up to #637: remove duplicate code and update tsam version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants