Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#624 Rename build_load_data to build_electricity_demand #642

Conversation

Ahmad-Wahid
Copy link
Contributor

fixes #624

Changes proposed in this Pull Request

  • Renamed build_load_data to build_electricity_demand

pre-commit-ci bot and others added 3 commits April 10, 2023 22:01
updates:
- [github.com/PyCQA/docformatter: v1.5.1 → v1.6.0](PyCQA/docformatter@v1.5.1...v1.6.0)
- [github.com/snakemake/snakefmt: v0.8.3 → v0.8.4](snakemake/snakefmt@v0.8.3...v0.8.4)
Signed-off-by: Ahmad <ahmedwahid16101@gmail.com>
Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ahmad-Wahid, cheers for this contribution!

There are a few more references to build_load_data in the repository (e.g. in the documentation). Could you change that to build_electricity_demand, too?

@Ahmad-Wahid
Copy link
Contributor Author

sure, I will update that.

Ahmad-Wahid and others added 4 commits April 14, 2023 20:58
Signed-off-by: Ahmad <ahmedwahid16101@gmail.com>
…lectricity_demand' into rename_build_load_data_2_build_electricity_demand
Signed-off-by: Ahmad <ahmedwahid16101@gmail.com>
@Ahmad-Wahid Ahmad-Wahid requested a review from fneum April 14, 2023 19:42
@Ahmad-Wahid
Copy link
Contributor Author

@fneum hey I'm not sure about this pre-commit.ci thing. It's failed. would you tell that how can I fix it? I'm still new to git

Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to worry about the pre-commit. It's likely because of the version update of docformatter.

There are 3 more references to build_load_data that should be adapted:

  • doc/preparation.rst
  • doc/release_notes.rst
  • scripts/build_electricity_demand.py -> mock_snakemake

Could you also add a release note in doc/release_notes.rst mentioning the renaming?

Then, we're good to merge.

- added a released note about the renaming of build_load_data to build_electricity_demand
@Ahmad-Wahid Ahmad-Wahid requested a review from fneum April 16, 2023 00:36
@fneum fneum merged commit d0c86a7 into PyPSA:master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename build_load_data to build_electricity_demand
2 participants