-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update config section #685
Conversation
for more information, see https://pre-commit.ci
…otting (need suggestion)
for more information, see https://pre-commit.ci
…to describe-config
for more information, see https://pre-commit.ci
@fneum @lisazeyen could one of you also have a look? In particular, at the documentation of the sector section at https://pypsa-eur--685.org.readthedocs.build/en/685/configuration.html#sector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! Super helpful!
I have made small adjustments here and there.
One thing to be careful about: When the documentation says percentage, I would put e.g. 20.7 for 20.7%, but in most cases the input requires 0.207. Maybe one could clarify this.
My other comment is stylistic. Could you check if it makes sense to adjust the column widths of the tables and give more width to the description?
Co-authored-by: Fabian Neumann <fabian.neumann@outlook.de>
for more information, see https://pre-commit.ci
Hey @virio-andreyana, there are still some unresolved issues. Would you look into them? |
Co-authored-by: Fabian Neumann <fabian.neumann@outlook.de>
for more information, see https://pre-commit.ci
Okay, so the simple suggestion have been added. Now, only a few problem is left.
Hmm, I believe that the reader is smart enough to know how the meaning of the percentage works. So long as they see the config default value.
I could try that, maybe by shortening the column for the attribute name, and values |
thanks @virio-andreyana, perhaps we use |
@fneum would you be fine with merging? |
The CSVs now have quite a few empty lines. Might cause problems. |
Otherwise, yes! |
@fneum thanks for looking over |
Actually this is a dilemma. So what I wanted to achieve is to have all of the table to have the same spacing. But since some attribute have letters longer than 22 letters, the table shifts to the right. Making the room for the description smaller. This is the case especially for sector.csv and industry.csv |
Sound reasonable. Let's keep the extra lines, then. In the docs it looks good. |
Update the documentation's config section. Pull out config comments to documentation.