Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harmonize output of solving rules #712

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Conversation

FabianHofmann
Copy link
Contributor

@FabianHofmann FabianHofmann commented Aug 2, 2023

only copy active configuration to results folder
use copy config for all solve rules
remove copying of environment

Changes proposed in this Pull Request

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

use copy config for all solve rules
remove copying of environment
@FabianHofmann FabianHofmann requested a review from fneum August 2, 2023 13:09
Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We could think of adding a commit-hash to n.meta, like abcd1234-dirty to follow version of preparation and solving scripts.

@FabianHofmann
Copy link
Contributor Author

LGTM. We could think of adding a commit-hash to n.meta, like abcd1234-dirty to follow version of preparation and solving scripts.

Indeed, and since we are storing the config in the network meta anyway, should we just get rid of the copy config for good?

@fneum
Copy link
Member

fneum commented Aug 2, 2023

Hmm, you're right that there's some duplication but maybe a YAML is easier to inspect ad-hoc.

@lisazeyen
Copy link
Contributor

I would favor keeping the .yaml file. It is also useful if you want to use it for a summary script of all scenarios since you do not have to read in a pypsa network to check the n.meta

@fneum fneum merged commit 8ae568d into master Aug 3, 2023
@fneum fneum deleted the harmonize-result-stucture branch August 3, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants