-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update calculations of retrofit costs #759
Conversation
for more information, see https://pre-commit.ci
Thanks, @ekatef for the PR. Looks good! CI is failing due to some internet connection problems, but let's wait till it's through. @lisazeyen, you approve? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm that the workflow runs with suggested data structure changes. But instead of moving the tabula data around, we could also change the respective path. Then the sector-bundle doesn't need updating (might be confusing if the files appears twice), i.e.
in rules/build_sector.smk
, change
data_tabula="data/retro/tabula-calculator-calcsetbuilding,csv",
to
data_tabula="data/bundle-sector/retro/tabula-calculator-calcsetbuilding.csv",
Thoughts ?
Agree, fixed. |
Looks good to me, only the CI needs to run through |
None of the changes affect the CI, since retrofitting path is not covered by tests. Therefore, I am merging without passing tests (URL connection error). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
The PR is aimed to update retrofit calculations to make the model work with
retro_endogen: false
. The main reasons why updates are needed is that data structure may have been altered and pandas version has changed.Changes proposed in this Pull Request
Apart of the code fixes, the datakit structure should be ajusted a bit:
tabula-calculator-calcsetbuilding.csv
should be moved to/pypsa-eur/data/retro
, where the workflow expects to find it.Checklist
envs/environment.yaml
.config.default.yaml
.doc/configtables/*.csv
.doc/release_notes.rst
is added.