Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add heat vent #791

Merged
merged 7 commits into from
Dec 4, 2023
Merged

add heat vent #791

merged 7 commits into from
Dec 4, 2023

Conversation

lisazeyen
Copy link
Contributor

@lisazeyen lisazeyen commented Dec 4, 2023 •
edited
Loading

Closes # (if applicable).

Add a vent for district heating

This PR should add a vent for district heating. Currently, with the must run condition for Fischer-Tropsch synthesis, waste heat usage enabled and decreasing heating demand (as assumed exogenously in the config default setting), pathway optimisation leads to infeasibilities in some investment periods since large Fischer-Tropsch capacities are needed in early years but the waste heat exceeds the heat demand in later investment periods.

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

fneum
fneum approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one stylistic comment.

scripts/prepare_sector_network.py Outdated Show resolved Hide resolved
@lisazeyen lisazeyen marked this pull request as ready for review December 4, 2023 11:29
@fneum fneum enabled auto-merge December 4, 2023 11:29
@lisazeyen lisazeyen disabled auto-merge December 4, 2023 12:54
@lisazeyen lisazeyen merged commit 35f2f29 into master Dec 4, 2023
3 of 5 checks passed
@lisazeyen lisazeyen deleted the heat-vent branch December 4, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fneum fneum fneum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lisazeyen @fneum