Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve waste heat and resistive heaters (issue1 and issue2) #813

Merged
merged 6 commits into from
Dec 28, 2023
Merged

Resolve waste heat and resistive heaters (issue1 and issue2) #813

merged 6 commits into from
Dec 28, 2023

Conversation

yerbol-akhmetov
Copy link
Contributor

@yerbol-akhmetov yerbol-akhmetov commented Dec 23, 2023 •
edited
Loading

Changes proposed in this Pull Request

Good day, here I propose changes to address ISSUE 1 (waste heat addition) and ISSUE 2 (resistive heater inclusion). Waste heat is currently only added if industry activated. Moreover, resistive heater is not added if boilers: false. This PR is aimed to solve these issues.

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

@martacki martacki merged commit 61c5415 into PyPSA:services_heat Dec 28, 2023
2 checks passed
@yerbol-akhmetov yerbol-akhmetov deleted the issue1_issue2 branch December 28, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martacki martacki martacki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yerbol-akhmetov @martacki