-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge recent ariadne advancements #884
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the DH share was being multiplied by the population weighting, reducing the DH share with multiple nodes.
Previously this was handled inside prepare_sector_network.py.
Now the script build_district_heat_share.py does what the old function create_nodes_for_heating() in prepare_sector_networks.py did. There is no need to build nodes lists for each heating sector, since all nodes have district heating now.
This makes the distribution of existing heating to urban/rural, residential/services and spatially more transparent.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
closes #860 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix: Do not reduce district heat share when building population-weighted
energy statistics. Previously the district heating share was being multiplied
by the population weighting, reducing the DH share with multiple nodes.
Move building of daily heat profile to its own rule
:mod:
build_hourly_heat_demand
from :mod:prepare_sector_network
.In :mod:
build_energy_totals
, district heating shares are now reported in aseparate file.
Move calculation of district heating share to its own rule
:mod:
build_district_heat_share
.Move building of distribution of existing heating to own rule
:mod:
build_existing_heating_distribution
. This makes the distribution ofexisting heating to urban/rural, residential/services and spatially more
transparent.