Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snakefile: allow to share resources in directory #906

Merged
merged 7 commits into from
Feb 5, 2024

Conversation

FabianHofmann
Copy link
Contributor

@FabianHofmann FabianHofmann commented Jan 31, 2024

CI: use test.sh script which can be executed locally

With this change, it should be faster and safer to run tests locally. By running

bash test.sh

or

./test.sh

you can run the same workflow as the CI on github. The test runs are using an encapsulated directory for the resources which does not interfere with the default resources. Therefore, it is easy to switch between low (i.e. in tests) and high (default) network resolution.

Closes #905

Changes proposed in this Pull Request

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

@FabianHofmann FabianHofmann marked this pull request as ready for review January 31, 2024 16:13
@FabianHofmann FabianHofmann requested a review from fneum February 1, 2024 08:28
Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a few deprecation warnings addressed, too.

rules/postprocess.smk Outdated Show resolved Hide resolved
rules/postprocess.smk Show resolved Hide resolved
rules/postprocess.smk Outdated Show resolved Hide resolved
@fneum fneum enabled auto-merge February 5, 2024 07:22
@fneum
Copy link
Member

fneum commented Feb 5, 2024

Sorry, plot_hydrogen_network.py needs the foresight param....

@fneum fneum merged commit 3198d8b into master Feb 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow shared resources in dedicated folder
2 participants