Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous bugfixes #980

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Miscellaneous bugfixes #980

merged 3 commits into from
Mar 19, 2024

Conversation

koen-vg
Copy link
Contributor

@koen-vg koen-vg commented Mar 19, 2024

I really do try to test my PRs, but somehow two typos slipped through in the most recent ones; I'm sorry! Here is the fix.

To make up for it I found and fixed a mistake in the logic of filling in missing years of total hydro production data. I've tested this and it works :) Used to throw an error (cannot cast Series to boolean) but also the calculation of which years were missing was the wrong way around.

Hope it's fine it package these two fixes in one PR just to avoid overrunning you with PRs.

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

koen-vg added 3 commits March 19, 2024 08:54
First, cannot cast pd index to boolean. Second, fix logic error of
mistakenly swapped difference in calculating missing years.
Preventing problems when parallel processes attempt to move the same
file to different resources directories.
@koen-vg
Copy link
Contributor Author

koen-vg commented Mar 19, 2024

If you will allow me, I tacked one more one-line bugfix to this PR; the natura.tiff file needs to be copied to resources instead of moved since otherwise multiple processes can try to move the same file away, and all but one will fail.

Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries @koen-vg! I didn't catch it in review either.

@fneum fneum merged commit 58a374d into PyPSA:master Mar 19, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants