Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More test cases - reached 80% coverage #156

Merged
merged 20 commits into from
Nov 10, 2018
Merged

More test cases - reached 80% coverage #156

merged 20 commits into from
Nov 10, 2018

Conversation

bact
Copy link
Member

@bact bact commented Nov 9, 2018

  • more test cases for POS taggers, spell checkers, thai2vec, tokenizers, transliterators, and Wordnet
  • handle None and empty input cases

@coveralls
Copy link

coveralls commented Nov 9, 2018

Coverage Status

Coverage increased (+7.9%) to 80.122% when pulling af83c4d on bact:dev into 694dbf7 on PyThaiNLP:dev.

@bact
Copy link
Member Author

bact commented Nov 9, 2018

AppVeyor failed because of network connection error- the TNC server did not respond in time.

@bact bact changed the title More test cases for tokenization More test cases Nov 9, 2018
@bact bact requested a review from wannaphong November 9, 2018 15:11
@wannaphong wannaphong mentioned this pull request Nov 9, 2018
@bact bact changed the title More test cases More test cases - reached 80% coverage Nov 10, 2018
@bact
Copy link
Member Author

bact commented Nov 10, 2018

80% แล้ว!

Note: Slower and slower build time

As the test coverage is improving, the build time for test is dramatically slower - as test cases are now hitting with functions that use some data models - and these models (like thai2vec, thainer, etc.) have to be downloaded fresh everytime for each single build.

For discussion on how to solve this, please join #144. The proposal is, if the user chose the relevant extras_require option and if the licenses are permitted, all required data models should be installed once at the pip install time.

Copy link
Member

@wannaphong wannaphong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge ได้เลยครับ

@bact bact merged commit fed1ceb into PyThaiNLP:dev Nov 10, 2018
@wannaphong wannaphong added this to the 1.8 milestone Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants