-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More test cases - reached 80% coverage #156
Conversation
bact
commented
Nov 9, 2018
•
edited
Loading
edited
- more test cases for POS taggers, spell checkers, thai2vec, tokenizers, transliterators, and Wordnet
- handle None and empty input cases
Merge from origin
AppVeyor failed because of network connection error- the TNC server did not respond in time. |
- more test cases for tokenize
- remove deepcut tests for now
80% แล้ว! Note: Slower and slower build timeAs the test coverage is improving, the build time for test is dramatically slower - as test cases are now hitting with functions that use some data models - and these models (like thai2vec, thainer, etc.) have to be downloaded fresh everytime for each single build. For discussion on how to solve this, please join #144. The proposal is, if the user chose the relevant extras_require option and if the licenses are permitted, all required data models should be installed once at the pip install time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge ได้เลยครับ