Add Thai Solar Date convert to Thai Lunar Date

[wannaphong]

Thank @cstorm125 for the function name.

What does this changes

Add Thai Solar Date convert to Thai Lunar Date

Fixed #993

Your checklist for this pull request

• Passed code styles and structures
• Passed code linting checks and unit test

[pep8speaks]

Hello @wannaphong! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-11-15 16:26:27 UTC

[coveralls]

coverage: 52.515% (+0.4%) from 52.102%
when pulling 99df362 on add-thai-lunar-date
into 630b355 on dev.

[bact]

Few issues

• There are some unused variables, see https://app.codacy.com/gh/PyThaiNLP/pythainlp/pull-requests/998/issues
• Variable and function names should follow conventions in PEP 8 https://peps.python.org/pep-0008/#function-and-variable-names
  • For example, instead of StartY, use start_y.
• Some variable names have a prefix i, probably as a convention from VBA to indicate that this variable is an Integer. Python doesn't have that convention. Actually, i here is for "input", still redundant (except in the context of i_date, since date is already used by Python)
  • So instead of iYear, we can use just year.
• The use of unnecessary XLMod() instead of a standard % for modulo

[bact]

LGTM

[sonarqubecloud]

Quality Gate failed

Failed conditions
20.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud