Fix: url validator #323
Merged
Fix: url validator #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalresistor
force-pushed
the
fix/url-validator-dos
branch
from
037d7d0
to
51172ad
Compare
digitalresistor
added a commit
that referenced
this pull request
Feb 1, 2019
|
I have requested a CVE for this vulnerability as a potential Denial of Service, will update CHANGES.rst and this ticket if it gets assigned. |
|
This has been assigned CVE-ID: CVE-2017-18361 |
mmerickel
reviewed
Feb 1, 2019
mmerickel
reviewed
Feb 1, 2019
digitalresistor
force-pushed
the
fix/url-validator-dos
branch
from
8057a73
to
fc4c4be
Compare
digitalresistor
added a commit
that referenced
this pull request
Feb 1, 2019
digitalresistor
force-pushed
the
fix/url-validator-dos
branch
from
fc4c4be
to
95b883a
Compare
digitalresistor
added a commit
that referenced
this pull request
Feb 1, 2019
digitalresistor
force-pushed
the
fix/url-validator-dos
branch
from
95b883a
to
b61b5f8
Compare
digitalresistor
added a commit
that referenced
this pull request
Feb 1, 2019
digitalresistor
force-pushed
the
fix/url-validator-dos
branch
from
b61b5f8
to
a9faff7
Compare
digitalresistor
added a commit
that referenced
this pull request
Feb 1, 2019
digitalresistor
force-pushed
the
fix/url-validator-dos
branch
from
a9faff7
to
9356db7
Compare
digitalresistor
added a commit
that referenced
this pull request
Feb 1, 2019
digitalresistor
force-pushed
the
fix/url-validator-dos
branch
from
9356db7
to
2ba8973
Compare
mmerickel
approved these changes
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the URL validator issue reported in #290.
As a side note, this can lead to anyone using this validator and for example deform to be vulnerable to a Denial of Service, since it basically sends Python into an infinite loop. We should back port as necessary, and or notify this as a security issue.
Closes #290