request object in pviews misses custom request methods

[merwok]

Here’s the setup:

• myapp includes mylib
• mylib.includeme calls add_request_method('user_service_client', get_user_service_client, reify=True)
• myapp uses traversal; there is a UserCollection with a __getitem__ method that uses request.user_service_client to see if the user ID is found in our user service.
• under pviews, request.user_service_client does not exist, causing traversal and pviews to fail.

After some interesting diving into pyramid.scripting, pyramid.bootstrap and pyramid.scripts.pviews, I found that bootstrap creates a request object and sets the custom attibutes on it (using the IRequestExtensions utility and _set_extensions method), but PViewsCommand._find_view creates a fresh request object. Thus, my custom request property is not defined when my resources get this request object.

I changed _find_view to take the request object from bootstrap (it already takes the registry) and my pviews command worked. 21 tests failed because of the changed signature; I don’t know if not creating a fresh request will cause issues for other pviews usecases, but unless someone objects, I’ll make a pull request with this change and fixed tests.

[merwok]

I lied: I noticed that pviews did not fail with AttributeError anymore, but I was not paying attention to the output: the matched resource was the root instead of the expected class three traversal levels down, so the fix is definitely more complicated than what I said.

[merwok]

Alternate fix idea: when the new request object is created in pviews, see if IRequestExtensions is registered and if yes, apply it to the new request. I’ll try that.

[mmerickel]

Yeah it's too bad that pviews doesn't use the request from bootstrap, I think it would be a lot cleaner. _find_views should just accept a request object instead of a url and a registry. Bleh, rewriting tests..

[mcdonc]

How did this know I meant to close it?

[merwok]

Opening PR message did say “this should close #1104”...

[mcdonc]

I did not know about this gh feature.

[merwok]

Well I was mostly joking :‑)