Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update request.invoke_exception_view to set request.exception #3030

Closed
mmerickel opened this issue May 3, 2017 · 0 comments · Fixed by #3031
Closed

update request.invoke_exception_view to set request.exception #3030

mmerickel opened this issue May 3, 2017 · 0 comments · Fixed by #3031
Milestone

Comments

@mmerickel
Copy link
Member

mmerickel commented May 3, 2017

Currently request.invoke_exception_view restores request.exception to whatever it was before when it completes. I think instead it should follow the behavior of the excview tween in #3029 and overwrite request.exception and request.exc_info if it manages to return a response. This will simplify the lives of most people who would want to use the method in trying to conform to this idea of having the request.exception match the response object it was used to create.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant