normalize excview tween to use request.invoke_exception_view
#3031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``request.exception`` and ``request.exc_info`` are set to the exception used to render the response but they are reset to their original values if no response could be rendered minor incompatibility in that ``request.response`` is restored after the excview tween but should not be an issue because a response is returned thus request.response should be ignored by anyone who cares.
digitalresistor
approved these changes
May 4, 2017
mmerickel
added a commit
that referenced
this pull request
May 4, 2017
mmerickel
added a commit
that referenced
this pull request
May 9, 2017
This was referenced Jun 26, 2017
This was referenced Jul 10, 2017
This was referenced Sep 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
request.exceptionandrequest.exc_infoare set to theexception used to render the response but they are reset to their
original values if no response could be rendered
minor incompatibility in that
request.responseis restored after theexcview tween but should not be an issue because a response is returned
thus request.response should be ignored by anyone who cares.
fixes #3030