-
Notifications
You must be signed in to change notification settings - Fork 886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow hyphens in project name #1376
Conversation
Convert hyphens in project_name to underscores in pkg_name
+1 LGTM |
Two things:
|
@tseaver, I added a test to make sure that hyphens in the project name are properly converted into underscores in the package name. I looked at setuptools and found setuptools.dist.check_packages(), which validates package names using the regular expression |
Hi Michael, Hi Tres, |
Thanks for backing out the extraneous changes via c1ef71c. This change looks good to me. |
Allow hyphens in project name
Thanks again! |
Thank you for maintaining this great descendant of Pylons. |
Convert hyphens in project_name to underscores in pkg_name