add InstancePropertyHelper and apply_request_extensions #1581
Conversation
|
LGTM |
|
That little edit to IRequestFactory was because IRequestFactory is a public api and IRequest is apparently not. So I didn't want the private api referenced from the public docstring. |
|
I had not realised that |
|
Well I actually thought it was. But it's private and just a marker interface actually. |
add InstancePropertyHelper and apply_request_extensions
|
|
||
| After invoking this method, the ``request`` should have the methods | ||
| and properties that were defined using | ||
| :meth:`pyramid.config.Configurator.add_request_method`. |
There was a problem hiding this comment.
Should we document how you would use extensions?
There was a problem hiding this comment.
I explicitly left extensions off of the public api documentation. It's there just for pyramid's hot route in the router. The IRequestExtensions interface is private and shouldn't be used/passed-in directly by anyone. We do this in a few other places in the code for testing hooks.
There was a problem hiding this comment.
We could name it _extensions if it would make you feel better.
No description provided.